Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug App Store workflows #1248

Merged
merged 22 commits into from
Dec 9, 2024
Merged

Debug App Store workflows #1248

merged 22 commits into from
Dec 9, 2024

Conversation

stevecassidy
Copy link
Contributor

Debug App Store workflows

JIRA Ticket

None

Description

Trying to get App Store build workflow working again.

Checklist

  • I have confirmed all commits have been signed.
  • I have added JSDoc style comments to any new functions or classes.
  • Relevant documentation such as READMEs, guides, and class comments are updated.

Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Copy link
Contributor

@PeterBaker0 PeterBaker0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but looks reasonable - just check out need to remove turbo cache - but your call.

Comment on lines 32 to 35
# Disable Turbo to see if that fixes the build - possible cache issue
# env:
# TURBO_TEAM: ${{ vars.TURBO_TEAM }}
# TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still necessary?

Comment on lines +20 to +33
<string>1.0.4</string>
<key>CFBundleURLTypes</key>
<array>
<dict>
<key>CFBundleURLName</key>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<string>au.edu.faims.fieldmark</string>
<key>CFBundleURLSchemes</key>
<array>
<string>org.fedarch.faims3</string>
<string>au.edu.faims.fieldmark</string>
</array>
</dict>
</array>
<key>CFBundleVersion</key>
<string>202409110011</string>
<string>202412012317</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so these will need to be env variables or some other build replacement later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they get changed by the prebuildConfig.sh script.

Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
@stevecassidy stevecassidy merged commit e54149d into main Dec 9, 2024
2 checks passed
@stevecassidy stevecassidy deleted the debug-app-store-workflow branch December 9, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants